From: Takashi Iwai Subject: Re: [PATCH] alsa-lib: alsa dshare endless playback of buffer Date: Mon, 28 Nov 2016 20:17:50 +0100 Message-ID: References: <1480072414-17398-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8DB9A266DD3 for ; Mon, 28 Nov 2016 20:17:52 +0100 (CET) In-Reply-To: <1480072414-17398-1-git-send-email-sutar.mounesh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: sutar.mounesh@gmail.com Cc: alsa-devel@alsa-project.org, Anant Agrawal , mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Fri, 25 Nov 2016 12:13:34 +0100, sutar.mounesh@gmail.com wrote: > > From: Anant Agrawal > > On snd_pcm_drain() the slave PCM driven via plugin DSHARE is not filled with > silence. Result is endless playback of buffer content until pcm is closed. > In ALSA pcm dshare plugin, called do_silence method to fix the issue. > > Signed-off-by: Anant Agrawal Applied, thanks. Takashi > > --- > --- alsa-lib-1.0.29.orig/src/pcm/pcm_dshare.c 2015-04-28 08:20:44.662995477 -0700 > +++ alsa-lib-1.0.29/src/pcm/pcm_dshare.c 2015-04-28 08:20:59.603077419 -0700 > @@ -195,6 +195,7 @@ > dshare->avail_max = avail; > if (avail >= pcm->stop_threshold) { > snd_timer_stop(dshare->timer); > + do_silence(pcm); > gettimestamp(&dshare->trigger_tstamp, pcm->tstamp_type); > if (dshare->state == SND_PCM_STATE_RUNNING) { > dshare->state = SND_PCM_STATE_XRUN; >