From: Takashi Iwai Subject: Re: [RFC PATCH v3 1/3] ALSA: hda - add DP mst verb support Date: Thu, 20 Oct 2016 17:27:24 +0200 Message-ID: References: <1476344977-147193-1-git-send-email-libin.yang@linux.intel.com> <1476344977-147193-2-git-send-email-libin.yang@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 263DA26581B for ; Thu, 20 Oct 2016 17:27:24 +0200 (CEST) In-Reply-To: <1476344977-147193-2-git-send-email-libin.yang@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: libin.yang@linux.intel.com Cc: libin.yang@intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 13 Oct 2016 09:49:35 +0200, libin.yang@linux.intel.com wrote: > > From: Libin Yang > > Add snd_hda_get_dev_select() and snd_hda_set_dev_select() functions > for DP MST audio support. > > Signed-off-by: Libin Yang > --- > sound/pci/hda/hda_codec.c | 73 ++++++++++++++++++++++++++++++++++++++++++++--- > sound/pci/hda/hda_codec.h | 3 ++ > 2 files changed, 72 insertions(+), 4 deletions(-) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index 9913be8..caa2c9d 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -311,9 +311,16 @@ int snd_hda_get_conn_index(struct hda_codec *codec, hda_nid_t mux, > } > EXPORT_SYMBOL_GPL(snd_hda_get_conn_index); > > - > -/* return DEVLIST_LEN parameter of the given widget */ > -static unsigned int get_num_devices(struct hda_codec *codec, hda_nid_t nid) > +/** > + * snd_hda_get_num_devices - get DEVLIST_LEN parameter of the given widget > + * @codec: the HDA codec > + * @nid: NID of the pin to parse > + * > + * Get the device entry number on the given widget. > + * This is a feature of DP MST audio. Each pin can > + * have several device entries in it. Try to fill more letters aligned in 80 columns, as we don't need to write a Haiku here. Takashi