From: Takashi Iwai Subject: Re: [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver Date: Tue, 02 Jun 2015 13:44:58 +0200 Message-ID: References: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> <1431341645-2457-6-git-send-email-vinod.koul@intel.com> <20150529174115.GR21577@sirena.org.uk> <20150601051358.GI3140@localhost> <20150602104233.GG14071@sirena.org.uk> <20150602111034.GP14071@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8FE9C26060C for ; Tue, 2 Jun 2015 13:44:59 +0200 (CEST) In-Reply-To: <20150602111034.GP14071@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Vinod Koul , liam.r.girdwood@linux.intel.com, patches.audio@intel.com, Jeeja KP , "Subhransu S. Prusty" List-Id: alsa-devel@alsa-project.org At Tue, 2 Jun 2015 12:10:34 +0100, Mark Brown wrote: > > On Tue, Jun 02, 2015 at 12:48:50PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > Why does the driver care though? IRQF_SHARED is advertising the > > > capabilities of the hander, not a requirement on the hardware - if the > > > interrupt physically can't be shared then the ability to share it will > > > never get used but that shouldn't matter. > > > Because the kernel doesn't guarantee the exclusiveness of irq handler > > registration as long as you pass IRQF_SHARED. That is, if we keep > > IRQF_SHARED and another driver tries to request_irq() for the same irq > > with again IRQF_SHARED. But this shouldn't happen with MSI. > > Sure, but how could that happen (given that the interrupt physically > can't be shared) and surely individual client drivers are the wrong > place to do this - Oh how can you trust BIOS setup? :) A wrong numbered IRQ is a most frequently seen problem (mostly not about MSI, though). > it's not like MSI is the only interrupt type that has > trouble with sharability, if this is an issue we need to have checks and > enforcement for I'd expect the interrupt controller to be flagging > itself as unsharable. Rather the sharable interrupt is exceptional, I'd say. That's the reason we have IRQF_SHARED, not IRQF_EXCLUSIVE. Takashi