From: Takashi Iwai Subject: Re: [PATCH] fm801: move to pcim_* and devm_* functions Date: Wed, 07 Jan 2015 12:27:34 +0100 Message-ID: References: <1420587617-28521-1-git-send-email-andy.shevchenko@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6D6912604BB for ; Wed, 7 Jan 2015 12:27:34 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andy Shevchenko Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org QXQgV2VkLCA3IEphbiAyMDE1IDEyOjU0OjQwICswMjAwLApBbmR5IFNoZXZjaGVua28gd3JvdGU6 Cj4gCj4gT24gV2VkLCBKYW4gNywgMjAxNSBhdCA5OjExIEFNLCBUYWthc2hpIEl3YWkgPHRpd2Fp QHN1c2UuZGU+IHdyb3RlOgo+ID4gQXQgV2VkLCAgNyBKYW4gMjAxNSAwMTo0MDoxNyArMDIwMCwK PiA+IEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiA+Pgo+ID4+IFRoZSBtYW5hZ2VkIGZ1bmN0aW9u cyBhbGxvdyB0byBnZXQgLT5wcm9iZSgpIGFuZCAtPnJlbW92ZSgpIHNpbXBsaWVyLgo+ID4+IFRo aXMgcGF0Y2ggY29udmVydHMgY29kZSB0byB1c2UgbWFuYWdlZCBmdW5jdGlvbnMuCj4gPgo+ID4g VGhpcyBkb2Vzbid0IHdvcmsgd2VsbCBiZWNhdXNlIG9mIHRoZSBvcmRlciBvZiByZWxlYXNlIGNh bGxzIGluCj4gPiBkZXZpY2VfcmVsZWFzZSgpLiAgZGV2cmVzX3JlbGVhc2VfYWxsKCkgaXMgY2Fs bGVkIGF0IGZpcnN0IGJlZm9yZQo+ID4gYW55dGhpbmcgZWxzZS4gIFRodXMgdGhlIGNhcmQncyBm cmVlIGNhbGxiYWNrIHdvdWxkIGJlIGNhbGxlZCBhZnRlcgo+ID4gaXQsIGFuZCBzbmRfZm04MDFf ZnJlZSgpIHRvdWNoZXMgdGhlIGhhcmR3YXJlIGJlZm9yZSBkaXNhYmxpbmcuCj4gPgo+IAo+IEht beKApiBJIGRpZG4ndCBnZXQgd2hhdCBtYWtlIHRob3NlIGNhbGxzLiBTb3VuZCBjb3JlPyBUaGUg ZHJpdmVyIGlzIGEKPiBub3JtYWwgUENJIGRyaXZlciwgc28gcmVzb3VyY2VzIHdpbGwgYmUgZnJl ZWQgKmFmdGVyKiAtPnJlbW92ZSgpIG9mCj4gZHJpdmVyIHdhcyBjYWxsZWQuCj4gUGxlYXNlLCBl bGFib3JhdGUuCgpBaCwgT0ssIHRoaXMgc2VlbXMgd29ya2luZywgYXMgdGhpcyBpcyB0aGUgbWFu YWdlZCAqcGNpKiBkZXZpY2UgdGhhdAppcyBhIHBhcmVudCBvZiB0aGUgY2FyZCBkZXZpY2UsIHRo dXMgaXQgc2hhbGwgYmUgcmVsZWFzZWQgYWZ0ZXIgdGhlCmNoaWxkcmVuLgoKQnV0IGFueSByZWFz b24gbm90IHRvIHVzZSBwY2ltX2lvbWFwX3JlZ2lvbnNfcmVxdWVzdF9hbGwoKT8KCgp0aGFua3Ms CgpUYWthc2hpCgo+IAo+ID4KPiA+IFRha2FzaGkKPiA+Cj4gPj4gV2hpbGUgaGVyZSByZW1vdmUg dGhlIGRlYWQgY29kZSBhbmQgZml4IHRoZSB2YWx1ZSBwcmludGVkIGluIGVycm9yCj4gPj4gbWVz c2FnZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2 Y2hlbmtvQGdtYWlsLmNvbT4KPiA+PiAtLS0KPiA+PiAgc291bmQvcGNpL2ZtODAxLmMgfCAyOSAr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9zb3VuZC9w Y2kvZm04MDEuYyBiL3NvdW5kL3BjaS9mbTgwMS5jCj4gPj4gaW5kZXggZGNkYTNjMS4uMjcwODUw MCAxMDA2NDQKPiA+PiAtLS0gYS9zb3VuZC9wY2kvZm04MDEuYwo+ID4+ICsrKyBiL3NvdW5kL3Bj aS9mbTgwMS5jCj4gPj4gQEAgLTExNzgsMTIgKzExNzgsOCBAQCBzdGF0aWMgaW50IHNuZF9mbTgw MV9mcmVlKHN0cnVjdCBmbTgwMSAqY2hpcCkKPiA+PiAgICAgICAgICAgICAgIHY0bDJfZGV2aWNl X3VucmVnaXN0ZXIoJmNoaXAtPnY0bDJfZGV2KTsKPiA+PiAgICAgICB9Cj4gPj4gICNlbmRpZgo+ ID4+IC0gICAgIGlmIChjaGlwLT5pcnEgPj0gMCkKPiA+PiAtICAgICAgICAgICAgIGZyZWVfaXJx KGNoaXAtPmlycSwgY2hpcCk7Cj4gPj4gICAgICAgcGNpX3JlbGVhc2VfcmVnaW9ucyhjaGlwLT5w Y2kpOwo+ID4+IC0gICAgIHBjaV9kaXNhYmxlX2RldmljZShjaGlwLT5wY2kpOwo+ID4+Cj4gPj4g LSAgICAga2ZyZWUoY2hpcCk7Cj4gPj4gICAgICAgcmV0dXJuIDA7Cj4gPj4gIH0KPiA+Pgo+ID4+ IEBAIC0xMjA2LDI4ICsxMjAyLDIzIEBAIHN0YXRpYyBpbnQgc25kX2ZtODAxX2NyZWF0ZShzdHJ1 Y3Qgc25kX2NhcmQgKmNhcmQsCj4gPj4gICAgICAgfTsKPiA+Pgo+ID4+ICAgICAgICpyY2hpcCA9 IE5VTEw7Cj4gPj4gLSAgICAgaWYgKChlcnIgPSBwY2lfZW5hYmxlX2RldmljZShwY2kpKSA8IDAp Cj4gPj4gKyAgICAgaWYgKChlcnIgPSBwY2ltX2VuYWJsZV9kZXZpY2UocGNpKSkgPCAwKQo+ID4+ ICAgICAgICAgICAgICAgcmV0dXJuIGVycjsKPiA+PiAtICAgICBjaGlwID0ga3phbGxvYyhzaXpl b2YoKmNoaXApLCBHRlBfS0VSTkVMKTsKPiA+PiAtICAgICBpZiAoY2hpcCA9PSBOVUxMKSB7Cj4g Pj4gLSAgICAgICAgICAgICBwY2lfZGlzYWJsZV9kZXZpY2UocGNpKTsKPiA+PiArICAgICBjaGlw ID0gZGV2bV9remFsbG9jKCZwY2ktPmRldiwgc2l6ZW9mKCpjaGlwKSwgR0ZQX0tFUk5FTCk7Cj4g Pj4gKyAgICAgaWYgKGNoaXAgPT0gTlVMTCkKPiA+PiAgICAgICAgICAgICAgIHJldHVybiAtRU5P TUVNOwo+ID4+IC0gICAgIH0KPiA+PiAgICAgICBzcGluX2xvY2tfaW5pdCgmY2hpcC0+cmVnX2xv Y2spOwo+ID4+ICAgICAgIGNoaXAtPmNhcmQgPSBjYXJkOwo+ID4+ICAgICAgIGNoaXAtPnBjaSA9 IHBjaTsKPiA+PiAgICAgICBjaGlwLT5pcnEgPSAtMTsKPiA+PiAgICAgICBjaGlwLT50ZWE1NzV4 X3R1bmVyID0gdGVhNTc1eF90dW5lcjsKPiA+PiAtICAgICBpZiAoKGVyciA9IHBjaV9yZXF1ZXN0 X3JlZ2lvbnMocGNpLCAiRk04MDEiKSkgPCAwKSB7Cj4gPj4gLSAgICAgICAgICAgICBrZnJlZShj aGlwKTsKPiA+PiAtICAgICAgICAgICAgIHBjaV9kaXNhYmxlX2RldmljZShwY2kpOwo+ID4+ICsg ICAgIGlmICgoZXJyID0gcGNpX3JlcXVlc3RfcmVnaW9ucyhwY2ksICJGTTgwMSIpKSA8IDApCj4g Pj4gICAgICAgICAgICAgICByZXR1cm4gZXJyOwo+ID4+IC0gICAgIH0KPiA+PiAgICAgICBjaGlw LT5wb3J0ID0gcGNpX3Jlc291cmNlX3N0YXJ0KHBjaSwgMCk7Cj4gPj4gICAgICAgaWYgKCh0ZWE1 NzV4X3R1bmVyICYgVFVORVJfT05MWSkgPT0gMCkgewo+ID4+IC0gICAgICAgICAgICAgaWYgKHJl cXVlc3RfaXJxKHBjaS0+aXJxLCBzbmRfZm04MDFfaW50ZXJydXB0LCBJUlFGX1NIQVJFRCwKPiA+ PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICBLQlVJTERfTU9ETkFNRSwgY2hpcCkpIHsK PiA+PiAtICAgICAgICAgICAgICAgICAgICAgZGV2X2VycihjYXJkLT5kZXYsICJ1bmFibGUgdG8g Z3JhYiBJUlEgJWRcbiIsIGNoaXAtPmlycSk7Cj4gPj4gKyAgICAgICAgICAgICBpZiAoZGV2bV9y ZXF1ZXN0X2lycSgmcGNpLT5kZXYsIHBjaS0+aXJxLCBzbmRfZm04MDFfaW50ZXJydXB0LAo+ID4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElSUUZfU0hBUkVELCBLQlVJTERfTU9ETkFN RSwgY2hpcCkpIHsKPiA+PiArICAgICAgICAgICAgICAgICAgICAgZGV2X2VycihjYXJkLT5kZXYs ICJ1bmFibGUgdG8gZ3JhYiBJUlEgJWRcbiIsIHBjaS0+aXJxKTsKPiA+PiAgICAgICAgICAgICAg ICAgICAgICAgc25kX2ZtODAxX2ZyZWUoY2hpcCk7Cj4gPj4gICAgICAgICAgICAgICAgICAgICAg IHJldHVybiAtRUJVU1k7Cj4gPj4gICAgICAgICAgICAgICB9Cj4gPj4gQEAgLTEyNDIsMTIgKzEy MzMsNiBAQCBzdGF0aWMgaW50IHNuZF9mbTgwMV9jcmVhdGUoc3RydWN0IHNuZF9jYXJkICpjYXJk LAo+ID4+ICAgICAgIC8qIGluaXQgbWlnaHQgc2V0IHR1bmVyIGFjY2VzcyBtZXRob2QgKi8KPiA+ PiAgICAgICB0ZWE1NzV4X3R1bmVyID0gY2hpcC0+dGVhNTc1eF90dW5lcjsKPiA+Pgo+ID4+IC0g ICAgIGlmIChjaGlwLT5pcnEgPj0gMCAmJiAodGVhNTc1eF90dW5lciAmIFRVTkVSX09OTFkpKSB7 Cj4gPj4gLSAgICAgICAgICAgICBwY2lfY2xlYXJfbWFzdGVyKHBjaSk7Cj4gPj4gLSAgICAgICAg ICAgICBmcmVlX2lycShjaGlwLT5pcnEsIGNoaXApOwo+ID4+IC0gICAgICAgICAgICAgY2hpcC0+ aXJxID0gLTE7Cj4gPj4gLSAgICAgfQo+ID4+IC0KPiA+PiAgICAgICBpZiAoKGVyciA9IHNuZF9k ZXZpY2VfbmV3KGNhcmQsIFNORFJWX0RFVl9MT1dMRVZFTCwgY2hpcCwgJm9wcykpIDwgMCkgewo+ ID4+ICAgICAgICAgICAgICAgc25kX2ZtODAxX2ZyZWUoY2hpcCk7Cj4gPj4gICAgICAgICAgICAg ICByZXR1cm4gZXJyOwo+ID4+IC0tCj4gPj4gMS44LjMuMTAxLmc3MjdhNDZiCj4gPj4KPiAKPiAK PiAKPiAtLSAKPiBXaXRoIEJlc3QgUmVnYXJkcywKPiBBbmR5IFNoZXZjaGVua28KPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWls aW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2Et cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==