From: Takashi Iwai Subject: Re: [PATCH 8/8] ALSA: Change return value for load_dsp_prepare() to -ENOSYS Date: Fri, 14 Sep 2012 11:01:29 +0200 Message-ID: References: <1347585358-2403-1-git-send-email-ian_minett@creativelabs.com> <1347585358-2403-9-git-send-email-ian_minett@creativelabs.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AB36B265CD2 for ; Fri, 14 Sep 2012 11:01:29 +0200 (CEST) In-Reply-To: <1347585358-2403-9-git-send-email-ian_minett@creativelabs.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ian Minett Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 13 Sep 2012 18:15:58 -0700, Ian Minett wrote: > > From: Ian Minett > > Signed-off-by: Ian Minett This depends on what is the expected. If the function call is mandatory for both cases with and without DSP loader implementation, just returning zero is more practical. In this case... well, maybe ca0132 is the only user, so I think it's OK to return an error like this. Takashi > diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h > index 159e07a..ac60300 100644 > --- a/sound/pci/hda/hda_codec.h > +++ b/sound/pci/hda/hda_codec.h > @@ -1164,7 +1164,7 @@ snd_hda_codec_load_dsp_prepare(struct hda_codec *codec, unsigned int format, > unsigned int size, > struct snd_dma_buffer *bufp) > { > - return 0; > + return -ENOSYS; > } > static inline void > snd_hda_codec_load_dsp_trigger(struct hda_codec *codec, bool start) {} > -- > 1.7.4.1 >