From: Takashi Iwai Subject: Re: [PATCH 2/2] ALSA: Integrate control based jack reporting with core jack reporting Date: Fri, 02 Mar 2012 08:16:56 +0100 Message-ID: References: <4F506816.1050201@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 641B6103D28 for ; Fri, 2 Mar 2012 08:16:59 +0100 (CET) In-Reply-To: <4F506816.1050201@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org At Fri, 02 Mar 2012 07:26:30 +0100, David Henningsson wrote: > > On 03/01/2012 06:48 PM, Takashi Iwai wrote: > > So, a question of "Line Out" to be hyphened or not to be hyphened. > > > > The problem is less serious than Hamlet, and I think we can get rid of > > the redundant hyphen. Not only because many women dislike hyphened > > names nowadays (as you can find easily in Google), > > Yes, it is also inspired by the global individualism movement, clearly > 'Line' and 'Out' do not want to appear to be dependent on each other. Yes, the modern time. "Line In" has a right to keep its name even after it being "Surround Out". > > the naming rule > > with a direction suffix looks more flexible, and I saw that both or > > Mark and David don't matter much (so written in their posts). > > > > The fix patch is below. David, if you think it's too bad (that makes > > your code too messy), please speak up. Or, this is utterly broken, > > also let me know. > > There is no problem with this change. But is it used for mixer controls > anywhere, or only jacks? So far I haven't seen a mixer control having > either 'Line-Out' nor 'Line Out' in it. Good point. I'll change it, too. > A followup, slightly more serious question is 'Line' vs 'Line In'. It > seems PulseAudio only supports 'Line' today, but adding support is trivial. It'd be safer if PA can support both. But I guess mixer controls will stay without "In" suffix. That is, when the directional suffix is omitted, it depends on the base type: the default for "Mic" is input, "Headphone" is output. And "Line" is input. > > thanks, > > > > Takashi > > > > --- > > From: Takashi Iwai > > Subject: [PATCH] ALSA: hda/realtek - Kill hyphnated names > > Nitpick: Missing "e" in "hyphen". Oops. > > Kill hyphens from "Line-Out" name strings, as suggested by Mark Brown. > > > > Signed-off-by: Takashi Iwai > > --- > > sound/pci/hda/hda_codec.c | 4 ++-- > > sound/pci/hda/patch_realtek.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > I think you should change 'Line-Out' to 'Line Out' on a more global > basis. A quick grep for 'Line-Out' shows hits (that are not comments) in > patch_realtek.c, patch_cirrus.c and patch_conexant.c, as well as in > ac97, aoa and parisc directories. At least the patch_cirrus one should > be changed IMO. That makes sense. > Also, in the sound/soc there seem to be plenty of hits for 'Line Output' > which could be changed to 'Line Out', mostly for consistency. Something > for Mark? I think we should standardize "Line Out" mixer control name at first, e.g. updating the outdated ControlNames.txt document. Anyway I'll leave ASoC part as is for now. Takashi