From: Takashi Iwai Subject: Re: [PATCH v4 5/6] core: add support for compress_offload Date: Thu, 22 Dec 2011 09:51:04 +0100 Message-ID: References: <1323070791-12620-1-git-send-email-vinod.koul@linux.intel.com> <1323766980-9350-6-git-send-email-vinod.koul@linux.intel.com> <1324541990.1641.10133.camel@vkoul-udesk3> <1324542706.1641.10135.camel@vkoul-udesk3> <1324543732.1641.10137.camel@vkoul-udesk3> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 81D1E24430 for ; Thu, 22 Dec 2011 09:51:07 +0100 (CET) In-Reply-To: <1324543732.1641.10137.camel@vkoul-udesk3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, lrg@ti.com, Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org At Thu, 22 Dec 2011 14:18:52 +0530, Vinod Koul wrote: > > On Thu, 2011-12-22 at 09:44 +0100, Takashi Iwai wrote: > > > > You can use WARN() or snd_BUG_ON(). > But WARN or snd_BUG_ON will continue execution and.... > So better log it and return error, right? Yes, write like if (snd_BUG_ON(!foo)) return -ESOMETHING; Takashi