From: Takashi Iwai Subject: Re: [PATCH] ice1724: Fix surround on Chaintech AV-710 Date: Sat, 10 Oct 2009 10:56:15 +0200 Message-ID: References: <4AD008DA.2060109@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 12B4C243DD for ; Sat, 10 Oct 2009 10:56:16 +0200 (CEST) In-Reply-To: <4AD008DA.2060109@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Robert Hancock Cc: Alsa-Devel List-Id: alsa-devel@alsa-project.org At Fri, 09 Oct 2009 22:08:58 -0600, Robert Hancock wrote: > > Fix the num_total_dacs setting for Chaintech AV710. The existing comment > that only PSDOUT0 is connected is correct, but since the card is using > packed AC97 mode to send 6 channels to the codec, num_total_dacs should be > set to 6 and not 2. This allows 6-channel surround to work. Also clarify > a comment regarding the additional WM8728 codec on this card (it's connected > to the SPDIF output and always receives the same data). > > Signed-off-by: Robert Hancock Applied now. Thanks. Takashi > > diff --git a/sound/pci/ice1712/amp.c b/sound/pci/ice1712/amp.c > index 3756430..bfcf989 100644 > --- a/sound/pci/ice1712/amp.c > +++ b/sound/pci/ice1712/amp.c > @@ -52,11 +52,13 @@ static int __devinit snd_vt1724_amp_init(struct snd_ice1712 *ice) > > /* only use basic functionality for now */ > > - ice->num_total_dacs = 2; /* only PSDOUT0 is connected */ > + /* VT1616 6ch codec connected to PSDOUT0 using packed mode */ > + ice->num_total_dacs = 6; > ice->num_total_adcs = 2; > > - /* Chaintech AV-710 has another codecs, which need initialization */ > - /* initialize WM8728 codec */ > + /* Chaintech AV-710 has another WM8728 codec connected to PSDOUT4 > + (shared with the SPDIF output). Mixer control for this codec > + is not yet supported. */ > if (ice->eeprom.subvendor == VT1724_SUBDEVICE_AV710) { > for (i = 0; i < ARRAY_SIZE(wm_inits); i += 2) > wm_put(ice, wm_inits[i], wm_inits[i+1]); >