From: Takashi Iwai Subject: Re: [PATCH] ASoC: Factor out I2C 8 bit address 8 bit data I/O Date: Mon, 07 Sep 2009 12:40:02 +0200 Message-ID: References: <4AA47845.8070403@samsung.com> <20090907101519.GA29898@rakim.wolfsonmicro.main> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 89BA81037FB for ; Mon, 7 Sep 2009 12:40:03 +0200 (CEST) In-Reply-To: <20090907101519.GA29898@rakim.wolfsonmicro.main> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: kyungmin.park@samsung.com, alsa-devel@alsa-project.org, Joonyoung Shim List-Id: alsa-devel@alsa-project.org At Mon, 7 Sep 2009 11:15:19 +0100, Mark Brown wrote: > > On Mon, Sep 07, 2009 at 12:04:37PM +0900, Joonyoung Shim wrote: > > This patch is for the AK4671 codec driver using this format. > > > Signed-off-by: Joonyoung Shim > > Applied, thanks. Where we are at it: Mark, could you fix the initialization of io_types[] in C99 style? For this case, C99 style initialization is suited better since some fields are optional now. Also, I find the current unbalanced hw_read/hw_write definitions uneasy. hw_read takes the codec instance while hw_write takes i2c instance (and hw_read_t is dead). It'd be nice if you can fix these as well. thanks, Takashi