From: Takashi Iwai Subject: Re: [PATCH v2] ASoC CS4270 codec device driver Date: Tue, 31 Jul 2007 14:13:42 +0200 Message-ID: References: <11858269303921-git-send-email-timur@freescale.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id CEC5924361 for ; Tue, 31 Jul 2007 14:13:42 +0200 (CEST) In-Reply-To: <11858269303921-git-send-email-timur@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 30 Jul 2007 15:22:10 -0500, Timur Tabi wrote: > > This patch adds ALSA SoC support for the Cirrus Logic CS4270 codec. The > following features are suppored: > > 1) Stand-alone and software mode > 2) Software mode via I2C only > 3) Master mode, not Slave > 4) No power management > > Signed-off-by: Timur Tabi Better now. But, I found that your patch can't be applied cleanly to the latest ALSA tree. Could you regenerate it for mm tree (or perex/alsa.git mm branch)? Another thing I noticed is that the comment style. /** is used for JavaDoc style comments, which are processed via kerneldoc. Normal comments should use simply /* instead. thanks, Takashi