From: Takashi Iwai Subject: Re: [2.6 patch] sound/core/control.c: remove dead code Date: Tue, 07 Nov 2006 13:45:40 +0100 Message-ID: References: <20061106183018.GB8099@stusta.de> <20061107123806.GE8099@stusta.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns1.suse.de [195.135.220.2]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id E1125255 for ; Tue, 7 Nov 2006 13:45:40 +0100 (MET) In-Reply-To: <20061107123806.GE8099@stusta.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Adrian Bunk Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@suse.cz List-Id: alsa-devel@alsa-project.org At Tue, 7 Nov 2006 13:38:06 +0100, Adrian Bunk wrote: > > On Tue, Nov 07, 2006 at 11:43:48AM +0100, Takashi Iwai wrote: > > At Mon, 6 Nov 2006 19:30:18 +0100, > > Adrian Bunk wrote: > > > > > > This patch removes some obviously dead code spotted by the Coverity > > > checker. > > > > > > Signed-off-by: Adrian Bunk > > > > I think it's a wrong fix. result could be > 0 indeed. > > > > Takashi > > > > > > > > --- linux-2.6/sound/core/control.c.old 2006-11-06 19:11:32.000000000 +0100 > > > +++ linux-2.6/sound/core/control.c 2006-11-06 19:11:52.000000000 +0100 > > > @@ -1267,23 +1267,23 @@ static ssize_t snd_ctl_read(struct file > > > if ((file->f_flags & O_NONBLOCK) != 0 || result > 0) { > > That is already checked here -> ^^^^^^^^^^ > > And after this point, result is never assigned any value. Ah, I see. Now applied it to ALSA tree. Thanks. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642