From: Takashi Iwai Subject: Re: [PATCH] ASoC: Drop invalid DMI fields when setting card long name from DMI info Date: Wed, 28 Jun 2017 16:22:10 +0200 Message-ID: References: <20170628070139.18340-1-mengdong.lin@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C5AB7266BC2 for ; Wed, 28 Jun 2017 16:22:11 +0200 (CEST) In-Reply-To: <20170628070139.18340-1-mengdong.lin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: mengdong.lin@linux.intel.com Cc: liam.r.girdwood@linux.intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@intel.com List-Id: alsa-devel@alsa-project.org On Wed, 28 Jun 2017 09:01:39 +0200, mengdong.lin@linux.intel.com wrote: > > From: Mengdong Lin > > Sometimes DMI fields may be invalid and so can't give useful vendor, > product or board info, such as "Type2 - Board Manufacturer" or > "Type1 - TBD by OEM". Including such invalid DMI fileds may create silly > card long name. So this patch creates a black list of invalid strings. > And if a DMI field contains any string in this list, it will be excluded > from the card long name. > > Signed-off-by: Mengdong Lin > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index cfa9cf1476f2..419b788fd801 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -69,6 +69,20 @@ static int pmdown_time = 5000; > module_param(pmdown_time, int, 0); > MODULE_PARM_DESC(pmdown_time, "DAPM stream powerdown time (msecs)"); > > +/* If a DMI filed contain strings in this blacklist (e.g. > + * "Type2 - Board Manufacturer" or "Type1 - TBD by OEM"), it will be taken > + * as invalid and dropped when setting the card long name from DMI info. > + */ > +static const char * const dmi_blacklist[] = { > + "To be filled by OEM", > + "TBD by OEM", > + "Default String", We found also a case with "Default string" (note the case-sensitive). thanks, Takashi