From: Takashi Iwai Subject: Re: [PATCH v2 1/2] ASoC: rt5645: Add support for Surface 3 tablet Date: Tue, 05 Jul 2016 08:41:03 +0200 Message-ID: References: <20160704165348.2558-1-stephenjust@gmail.com> <20160704165348.2558-2-stephenjust@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 537212654F6 for ; Tue, 5 Jul 2016 08:41:04 +0200 (CEST) In-Reply-To: <20160704165348.2558-2-stephenjust@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Stephen Just Cc: Vinod Koul , alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org On Mon, 04 Jul 2016 18:53:47 +0200, Stephen Just wrote: > > * Add a dmi match for Surface 3 > * Add ACPI match "10EC5640" > > The Surface 3 tablet identifies the codec in ACPI as > 10EC5640, but other devices use this identifier to match > the rt5640 codec. However, the probe code for each driver > will filter out mismatches. > > Cc: Mark Brown > Cc: Vinod Koul > Signed-off-by: Stephen Just > --- > sound/soc/codecs/rt5645.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > v1 -> v2: No change > > diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c > index 3c6594d..761ca88 100644 > --- a/sound/soc/codecs/rt5645.c > +++ b/sound/soc/codecs/rt5645.c > @@ -3531,6 +3531,7 @@ MODULE_DEVICE_TABLE(i2c, rt5645_i2c_id); > static const struct acpi_device_id rt5645_acpi_match[] = { > { "10EC5645", 0 }, > { "10EC5650", 0 }, > + { "10EC5640", 0 }, Better to put in the right order. Takashi