From: Takashi Iwai Subject: Re: [PATCH] topology: fix file permissions for output file to 0600 Date: Tue, 11 Aug 2015 15:36:00 +0200 Message-ID: References: <1439299559-5051-1-git-send-email-liam.r.girdwood@linux.intel.com> <1439299559-5051-2-git-send-email-liam.r.girdwood@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id EC407260542 for ; Tue, 11 Aug 2015 15:36:00 +0200 (CEST) In-Reply-To: <1439299559-5051-2-git-send-email-liam.r.girdwood@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org On Tue, 11 Aug 2015 15:25:59 +0200, Liam Girdwood wrote: > > File was incorrectly world rwx. > > Signed-off-by: Liam Girdwood Because of the problems I reported in the previous mail, I applied only the first patch (renaming OBJECT_TYPE_*) in v2 series, so far. So, it's better to fold these two fixes into the last patch. Then submit v3 after fixing other reported issues. thanks, Takashi > --- > src/topology/parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/topology/parser.c b/src/topology/parser.c > index 5544517..993f70d 100644 > --- a/src/topology/parser.c > +++ b/src/topology/parser.c > @@ -267,7 +267,7 @@ int snd_tplg_build_file(snd_tplg_t *tplg, const char *infile, > int err = 0; > > tplg->out_fd = > - open(outfile, O_RDWR | O_CREAT, S_IRWXU | S_IRWXG | S_IRWXO); > + open(outfile, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR); > if (tplg->out_fd < 0) { > SNDERR("error: failed to open %s err %d\n", > outfile, -errno); > -- > 2.1.4 >