From: Takashi Iwai Subject: Re: HDMI hotplug on Skylake when power well is off Date: Fri, 17 Jul 2015 15:05:15 +0200 Message-ID: References: <55A62252.1050506@canonical.com> <20150716083908.GI5086@localhost> <55A77A8A.2080101@canonical.com> <20150716113514.GL5086@localhost> <55A7B383.6020206@canonical.com> <20150717111429.GP5086@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 46A2B2612DF for ; Fri, 17 Jul 2015 15:05:15 +0200 (CEST) In-Reply-To: <20150717111429.GP5086@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: libin.yang@intel.com, "Lin, Mengdong" , "alsa-devel@alsa-project.org" , David Henningsson List-Id: alsa-devel@alsa-project.org On Fri, 17 Jul 2015 13:14:29 +0200, Vinod Koul wrote: > > On Thu, Jul 16, 2015 at 03:37:07PM +0200, David Henningsson wrote: > > +static void i915_audio_component_hotplug_notify(struct hdac_bus *bus, > > + const struct i915_audio_hotplug_info *info) > > +{ > > + struct hda_codec *codec; > this should be hdac_device as core doesnt know hda_codec Yes, hdac_device is the core part of the codec device struct. > > + > > + codec_dbg("Received HDMI hotplug callback (connector = %s, plugged in = %d)", > > + info->connector_name, (int) info->plugged_in); > > + > > + for (i = 0; i <= MAX_CODEC_ADDRESS; i++) > > + if (bus->caddr_tbl[i] && bus->caddr_tbl[i]->hotplug_notify) > > + bus->caddr_tbl[i]->hotplug_notify(bus->caddr_tbl[i], info); > > +} > > Rest looks good :) I prefer traversing over the list like: struct hdac_device *codec; list_for_each_entry(codec, &bus->list, list) { if (codec->hotplug_notify) codec->hotplug_notify(codec, info); } thanks, Takashi