From: Takashi Iwai Subject: Re: [PATCH] ASoC: mc13783: Ensure we only try to dereference valid of_nodes Date: Wed, 08 Oct 2014 18:12:10 +0200 Message-ID: References: <1412779204-30876-1-git-send-email-broonie@kernel.org> <20141008155015.GF4609@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 16F44260478 for ; Wed, 8 Oct 2014 18:12:11 +0200 (CEST) In-Reply-To: <20141008155015.GF4609@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org At Wed, 8 Oct 2014 16:50:15 +0100, Mark Brown wrote: > > On Wed, Oct 08, 2014 at 05:06:15PM +0200, Takashi Iwai wrote: > > > I'd move the declaration of np into if block, too, so that it won't be > > referred in other places. > > I generally dislike that style outside of very large functions; it's not > typical for C. OK, it's a matter of taste. A typical bikeshed topic, we can spend hours about this :) Takashi