From: Takashi Iwai Subject: Re: [PATCH 1/1] Add USB audio quirk supporting Roland VG-99 advanced mode Date: Sun, 21 Oct 2012 10:40:37 +0200 Message-ID: References: <1350723664-7368-1-git-send-email-pete.leigh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B1A0D264F0B for ; Sun, 21 Oct 2012 10:40:40 +0200 (CEST) In-Reply-To: <1350723664-7368-1-git-send-email-pete.leigh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: pete.leigh@gmail.com Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 20 Oct 2012 10:01:04 +0100, pete.leigh@gmail.com wrote: > > From: Pete Leigh > > > Signed-off-by: Pete Leigh Could you give a bit more descriptive commit log? I see you put more in comments, but it'd be also good to have more information in the changelog. thanks, Takashi > > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h > index 88d8ceb..ffeabf8 100644 > --- a/sound/usb/quirks-table.h > +++ b/sound/usb/quirks-table.h > @@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"), > } > }, > { > + /* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1 > + * kHz. In standard mode, the device has ID 0582:00b3, and offers > + * 16-bit PCM at 44.1 kHz with no MIDI. > + */ > + USB_DEVICE(0x0582, 0x00b2), > + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { > + .vendor_name = "Roland", > + .product_name = "VG-99", > + .ifnum = QUIRK_ANY_INTERFACE, > + .type = QUIRK_COMPOSITE, > + .data = (const struct snd_usb_audio_quirk[]) { > + { > + .ifnum = 0, > + .type = QUIRK_AUDIO_STANDARD_INTERFACE > + }, > + { > + .ifnum = 1, > + .type = QUIRK_AUDIO_STANDARD_INTERFACE > + }, > + { > + .ifnum = 2, > + .type = QUIRK_MIDI_FIXED_ENDPOINT, > + .data = & (const struct snd_usb_midi_endpoint_info) { > + .out_cables = 0x0003, > + .in_cables = 0x0003 > + } > + }, > + { > + .ifnum = -1 > + } > + } > + } > +}, > +{ > /* Roland SonicCell */ > USB_DEVICE(0x0582, 0x00c2), > .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { > -- > 1.7.11.7 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >