From: Takashi Iwai Subject: Re: [PATCH ALSA HDA 1/1] Fix alc662_dac_nid and change 6stack-dig to 5stack-dig Date: Wed, 06 Apr 2011 15:07:33 +0200 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id EB7A21037EE for ; Wed, 6 Apr 2011 15:07:37 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: ALSA Development Mailing List List-Id: alsa-devel@alsa-project.org At Wed, 6 Apr 2011 20:59:58 +0800, Raymond Yau wrote: > > 2011/4/6 Takashi Iwai > > > At Wed, 6 Apr 2011 16:29:56 +0800, > > Raymond Yau wrote: > > > > > > 2011/4/6 Takashi Iwai > > > > > > > At Wed, 6 Apr 2011 15:35:16 +0800, > > > > Raymond Yau wrote: > > > > > > > > > > 2011/4/6 Takashi Iwai > > > > > > > > > > > At Tue, 5 Apr 2011 22:59:29 +0800, > > > > > > Raymond Yau wrote: > > > > > > > > > > > > > > Fix alc662_dac_nid and change "6stack-dig" to "5stack-dig" > > > > > > > > > > > > > > alc662 series only have 3 stereo DAC , so it can only support > > > > 5stack-dig > > > > > > > instead of 6stack-dig > > > > > > > > > > > > Applied now. Thanks. > > > > > > > > > > > > > > > > > > Takashi > > > > > > > > > > > > > > > > The other problem is this patch > > > > > > > > > > { .id = 0x10ec0892, .name = "ALC892", .patch = patch_alc662 }, > > > > > > > > > > > > > > > > http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=274693f37090ada2cadd09944ab883f05ea6ebe6 > > > > > > > > > > ALC892 provides ten DAC channels that simultaneously support 7.1 > > channel > > > > > sound playback, plus 2 channels of independent stereo sound output > > > > (multiple > > > > > streaming) through the front panel stereo outputs. > > > > > > > > > > It seem that there is no specific code to distinguish a 10 channels > > > > alc892 > > > > > from those 6 channels alc6xx > > > > > > > > Yeah, but there is no quirks specific to alc892. > > > > > > > > Remember that the final goal is to remove all model-quirks from the > > > > driver. > > > > > > > > > > > > Takashi > > > > > > > > > > My patch reduce the size of alc662_dac_nid may be wrong if the driver > > intend > > > to use alc662_auto_fill_dac_nids() to handle 6, 8 , 10 channels > > > > Don't worry, alc662_dac_nids is used only for the fixed quirks. > > The auto-parser doesn't use these fixed defined pin arrays. > > > > > > Takashi > > > > The bug for 10 channels alc892 is in alc662_mix_to_dac, it should return > [Audio Output ]0x5 for [Audiomixer 0x0f] -- side channel if model=auto is > used for 6stack OK, but it's irrelevant with your patch :) I'll fix it later. thanks, Takashi > static inline hda_nid_t alc662_mix_to_dac(hda_nid_t nid) > { > if (nid == 0x0f) > return 0x02; > else if (nid >= 0x0c && nid <= 0x0e) > return nid - 0x0c + 0x02; > else if (nid == 0x26) /* ALC887-VD has this DAC too */ > return 0x25; > else > return 0; > } > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >