From: Takashi Iwai Subject: Re: [Alsa-user] found bug, fixed bug, cannot tell anyone Date: Fri, 15 Aug 2008 09:25:35 +0200 Message-ID: References: <001d01c8fe5e$3e4eed40$0402a8c0@sj4> <48A52E1F.4060303@keyaccess.nl> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id C45BF24466 for ; Fri, 15 Aug 2008 09:25:35 +0200 (CEST) In-Reply-To: <48A52E1F.4060303@keyaccess.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Rene Herman Cc: alsa-user@lists.sourceforge.net, ALSA devel , Wesley Johnson List-Id: alsa-devel@alsa-project.org At Fri, 15 Aug 2008 09:19:59 +0200, Rene Herman wrote: > > On 14-08-08 22:36, Wesley Johnson wrote: > > > BUG: > > When you try to compile driver for ens1371 by itself the compile will fail. > > The driver for ens1371 has an include of the file for ens1370, but the > > makefule does not have this dependency > > so the ens1370 file is missing. The dev team is probably always compiling > > for all. > > > > Diff file that fixes this problem follows. > > > > *** pci/Makefile.orig Mon Jul 14 02:53:57 2008 > > --- pci/Makefile Thu Jul 17 21:25:42 2008 > > *************** > > *** 27,34 **** > > --- 27,35 ---- > > atiixp_modem.c: atiixp_modem.patch > > $(SND_TOPDIR)/alsa-kernel/pci/atiixp_modem.c > > bt87x.c: bt87x.patch $(SND_TOPDIR)/alsa-kernel/pci/bt87x.c > > cmipci.c: cmipci.patch $(SND_TOPDIR)/alsa-kernel/pci/cmipci.c > > ens1370.c: ens1370.patch $(SND_TOPDIR)/alsa-kernel/pci/ens1370.c > > + ens1371.c: ens1370.c > > I expect this should be a straight copy of the ens1370.c line but never > use the standalone alsa-driver package. Now that we're on alsa-devel, > people who do will reply though. The fix looks correct to me. ens1371.c includes ens1370 with an additional define. So, it actually depends on it. Takashi