From: Takashi Iwai Subject: Re: [PATCH] ALSA driver for SGI O2 audio board Date: Thu, 10 Jul 2008 02:15:26 +0200 Message-ID: References: <20080704234559.C959CFB63A@solo.franken.de> <20080709175059.GA10046@alpha.franken.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8D5022447D for ; Wed, 9 Jul 2008 20:15:29 +0200 (CEST) In-Reply-To: <20080709175059.GA10046@alpha.franken.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Thomas Bogendoerfer Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 9 Jul 2008 19:50:59 +0200, Thomas Bogendoerfer wrote: > > On Mon, Jul 07, 2008 at 05:57:06PM +0200, Takashi Iwai wrote: > > > + /* allocate IRQs */ > > > + for (i = 0; i < ARRAY_SIZE(snd_sgio2_isr_table); i++) { > > > + if (request_irq(snd_sgio2_isr_table[i].irq, > > > + snd_sgio2_isr_table[i].isr, > > > + IRQF_SHARED, > > > + snd_sgio2_isr_table[i].desc, > > > + &chip->channel[snd_sgio2_isr_table[i].idx])) { > > > + snd_sgio2audio_free(chip); > > > + printk(KERN_ERR "sgio2audio: cannot allocate irq %d\n", > > > + snd_sgio2_isr_table[i].irq); > > > + return -EBUSY; > > > + } > > > + } > > > > If there are shared interrupts, they could be called before the > > initialization below. So, safer to move after the init. > > they can't be shared and it's already done before any hardware init. Then any reason to pass IRQF_SHARED? Takashi