From: Takashi Iwai Subject: Re: [PATCH 1/5] ASoC: Build files Date: Tue, 19 Sep 2006 14:20:08 +0200 Message-ID: References: <1158326252.22950.64.camel@localhost.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1158326252.22950.64.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Liam Girdwood Cc: alsa-devel List-Id: alsa-devel@alsa-project.org At Fri, 15 Sep 2006 14:17:32 +0100, Liam Girdwood wrote: > > Index: alsa-kernel/soc/Kconfig > =================================================================== > --- /dev/null > +++ alsa-kernel/soc/Kconfig > @@ -0,0 +1,18 @@ > +# > +# SoC audio configuration > +# > + > +menu "SoC audio support" > + > +config SND_SOC > + tristate "SoC audio support" Don't you need dependencies? Also, changes for Kconfig and Makefile are usually the last patch so that you don't break build. A minor issue, though... Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV