From: Takashi Iwai Subject: Re: [PATCHv2] hda: Fix 1-minute detection delay when i915 module is not available Date: Sat, 27 Jul 2019 08:33:21 +0200 Message-ID: References: <20190726214702.kxi2gavlieiwyf7q@function> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12788F80134 for ; Sat, 27 Jul 2019 08:33:23 +0200 (CEST) In-Reply-To: <20190726214702.kxi2gavlieiwyf7q@function> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Samuel Thibault Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, 931507@bugs.debian.org List-Id: alsa-devel@alsa-project.org On Fri, 26 Jul 2019 23:47:02 +0200, Samuel Thibault wrote: > > Distribution installation images such as Debian include different sets > of modules which can be downloaded dynamically. Such images may notably > include the hda sound modules but not the i915 DRM module, even if the > latter was enabled at build time, as reported on > https://bugs.debian.org/931507 > > In such a case hdac_i915 would be linked in and try to load the i915 > module, fail since it is not there, but still wait for a whole minute > before giving up binding with it. > > This fixes such as case by only waiting for the binding if the module > was properly loaded (or module support is disabled, in which case i915 > is already compiled-in anyway). > > Signed-off-by: Samuel Thibault Applied with a slight coding style fix in my side. Also added Fixes and Cc-to-stable tags. At the next time, please check the patch before submission via checkpatch.pl. Thanks! Takashi