From: Takashi Iwai Subject: Re: [PATCH] gus: add a check of the status of snd_ctl_add Date: Tue, 01 Jan 2019 09:53:52 +0100 Message-ID: References: <20181226014052.70937-1-kjlu@umn.edu> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 09F88267B9C for ; Tue, 1 Jan 2019 09:53:53 +0100 (CET) In-Reply-To: <20181226014052.70937-1-kjlu@umn.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kangjie Lu Cc: alsa-devel@alsa-project.org, pakki001@umn.edu, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 26 Dec 2018 02:40:51 +0100, Kangjie Lu wrote: > > snd_ctl_add() could fail, so let's check its status and issue an error > message if it indeed fails. > > Signed-off-by: Kangjie Lu The function itself prints the error in most of useful cases, so the extra error here would be superfluous. thanks, Takashi