From: Takashi Iwai Subject: Re: [PATCH v4 12/12] ALSA: line6: Add hwdep interface to access the POD control messages Date: Mon, 19 Sep 2016 23:06:07 +0200 Message-ID: References: <1470942147-19848-1-git-send-email-dev@andree.sk> <1474225172-32081-1-git-send-email-dev@andree.sk> <1474225172-32081-13-git-send-email-dev@andree.sk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 00B9226655F for ; Mon, 19 Sep 2016 23:06:07 +0200 (CEST) In-Reply-To: <1474225172-32081-13-git-send-email-dev@andree.sk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andrej Krutak Cc: stefanha@gmail.com, alsa-devel@alsa-project.org, grabner@icg.tugraz.at List-Id: alsa-devel@alsa-project.org On Sun, 18 Sep 2016 20:59:32 +0200, Andrej Krutak wrote: > @@ -156,6 +166,15 @@ struct usb_line6 { > /* Length of message to be processed, generated from MIDI layer */ > int message_length; > > + /* Circular buffer for non-MIDI control messages */ > + struct { > + struct mutex read_lock; > + wait_queue_head_t wait_queue; > + int active:1; This should be unsigned int. Otherwise 1 bit int is handled as -1. Takashi