From: Takashi Iwai Subject: Re: [PATCH v5 0/2] amidi delay option Date: Mon, 22 Aug 2016 13:47:25 +0200 Message-ID: References: <20160815163734.17658-1-eu@felipetonello.com> <57B21E09.2030900@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 5BDC42668F9 for ; Mon, 22 Aug 2016 13:47:27 +0200 (CEST) In-Reply-To: <57B21E09.2030900@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Felipe F. Tonello" Cc: alsa-devel@alsa-project.org, Takashi Sakamoto List-Id: alsa-devel@alsa-project.org On Mon, 15 Aug 2016 21:54:49 +0200, Takashi Sakamoto wrote: > > Hi, > > On Aug 16 2016 01:37, Felipe F. Tonello wrote: > > Small improvement to amidi, adding useful functionality. > > > > changes from v4: > > * simplified code > > > > changes from v3: > > * fixed a bug if memchr() returns NULL > > > > changes from v2: > > * only check of end of sysex (0xf7) > > * use memchr() instead of direct loop approach > > * fixed commit message > > > > changes from v1: > > * remove delay in between any MIDI message, only SysEx > > * added patch to use getopt_long() arguments > > > > Felipe F. Tonello (2): > > amidi: add delay option > > amidi: use GNU getopt_long() proper argument names > > > > amidi/amidi.1 | 14 ++++++++++++++ > > amidi/amidi.c | 61 +++++++++++++++++++++++++++++++++++++++++++---------------- > > 2 files changed, 59 insertions(+), 16 deletions(-) > > Please notice the other developers' work. Clemens already posted his > patchset with similar improvements. > > http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111737.html > > And I reviewed and tested it. > http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111745.html > > It's not merged yet, because subsystem maintainer has a summer vacation. > http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111741.html > > It's better for you to wait for merging or work based on Clemens' > patchset, I think. Yep, now Clemens' patches were merged to git tree. Please rebase and resubmit if anything is missing. thanks, Takashi