From: Takashi Iwai Subject: Re: [PATCH v1 1/4] ALSA: fm801: explicitly free IRQ line Date: Sun, 20 Dec 2015 22:34:16 +0100 Message-ID: References: <1450466053-52170-1-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 4DB4A2607C8 for ; Sun, 20 Dec 2015 22:34:13 +0100 (CET) In-Reply-To: <1450466053-52170-1-git-send-email-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andy Shevchenko Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Fri, 18 Dec 2015 20:14:10 +0100, Andy Shevchenko wrote: > > Otherwise we will have a warning on ->remove() since device is a PCI one. > > WARNING: CPU: 4 PID: 1411 at /home/andy/prj/linux/fs/proc/generic.c:575 remove_proc_entry+0x137/0x160() > remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'snd_fm801' > > Fixes: 5618955c4269 (ALSA: fm801: move to pcim_* and devm_* functions) > Signed-off-by: Andy Shevchenko > --- > The patch series has been tested on SF64-PCR card. Applied all four patches. Thanks. Takashi > sound/pci/fm801.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/fm801.c b/sound/pci/fm801.c > index 1fdd92b6..f57847c 100644 > --- a/sound/pci/fm801.c > +++ b/sound/pci/fm801.c > @@ -1165,6 +1165,8 @@ static int snd_fm801_free(struct fm801 *chip) > cmdw |= 0x00c3; > fm801_writew(chip, IRQ_MASK, cmdw); > > + devm_free_irq(&chip->pci->dev, chip->irq, chip); > + > __end_hw: > #ifdef CONFIG_SND_FM801_TEA575X_BOOL > if (!(chip->tea575x_tuner & TUNER_DISABLED)) { > -- > 2.6.4 > > . >