From: Takashi Iwai Subject: Re: [PATCH 1/2] ALSA: hda - skip runtime PM if async probe is not finished Date: Tue, 28 Jul 2015 07:39:24 +0200 Message-ID: References: <1438032894-8472-1-git-send-email-ullysses.a.eoff@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1E0A426525B for ; Tue, 28 Jul 2015 07:39:25 +0200 (CEST) In-Reply-To: <1438032894-8472-1-git-send-email-ullysses.a.eoff@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "U. Artie Eoff" Cc: libin.yang@intel.com, alsa-devel@alsa-project.org, zhuo-hao.lee@intel.com List-Id: alsa-devel@alsa-project.org On Mon, 27 Jul 2015 23:34:53 +0200, U. Artie Eoff wrote: > > Crash can occur if runtime PM is triggered before the async probe > finishes via the azx_firmware_cb when CONFIG_SND_HDA_PATCH_LOADER > is defined. > > Don't execute PM ops if the async probe has not completed yet. > > The probe is finished when chip->running is true. > > Signed-off-by: U. Artie Eoff > --- > sound/pci/hda/hda_intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 735bdcb04ce8..b729b25a6ad6 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1023,7 +1023,7 @@ static int azx_runtime_idle(struct device *dev) > > chip = card->private_data; > hda = container_of(chip, struct hda_intel, chip); > - if (chip->disabled || hda->init_failed) > + if (chip->disabled || hda->init_failed || !chip->running) > return 0; For !chip->running, it's better to return -EBUSY. The disabled and init_failed flags are checked in runtime_suspend() and runtime_resume() to skip the whole procedures, too. And I guess the check of chip->running should suffice even without the second patch. It assures that the bus is powered on. thanks, Takashi