From: Takashi Iwai Subject: Re: [PATCH] ALSA: snd-usb-usx2y: fix start frame mask Date: Wed, 02 Oct 2013 15:48:17 +0200 Message-ID: References: <1380721197-4889-1-git-send-email-zonque@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 2C4DA265139 for ; Wed, 2 Oct 2013 15:45:38 +0200 (CEST) In-Reply-To: <1380721197-4889-1-git-send-email-zonque@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, guido.aulisi@gmail.com List-Id: alsa-devel@alsa-project.org At Wed, 2 Oct 2013 15:39:57 +0200, Daniel Mack wrote: > > This patch is based on a change proposed by Guido Aulisi in a > discussion on LAU which can be followed here: > > http://linuxaudio.org/mailarchive/lau/2013/5/20/200177 > > Cc: fzu@wemgehoertderstaat.de > Original-code-by: Guido Aulisi > Tested-by: Dr Nicholas J Bailey > Signed-off-by: Daniel Mack Why this fixes the issue at all? There is no explanation in the thread. If any, the sanity check there is simply bogus for ehci, and it'd be better to get rid of it completely. thanks, Takashi > --- > sound/usb/usx2y/usbusx2yaudio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c > index 63fb521..cd16fcc 100644 > --- a/sound/usb/usx2y/usbusx2yaudio.c > +++ b/sound/usb/usx2y/usbusx2yaudio.c > @@ -328,7 +328,7 @@ static void i_usX2Y_urb_complete(struct urb *urb) > usX2Y_error_urb_status(usX2Y, subs, urb); > return; > } > - if (likely((urb->start_frame & 0xFFFF) == (usX2Y->wait_iso_frame & 0xFFFF))) > + if (likely((urb->start_frame & 0x03FF) == (usX2Y->wait_iso_frame & 0x03FF))) > subs->completed_urb = urb; > else { > usX2Y_error_sequence(usX2Y, subs, urb); > -- > 1.8.3.1 >