From: Takashi Iwai Subject: Re: [PATCH 1/3] [ALSA] hda - Support rereading widgets under the function group Date: Fri, 08 Feb 2013 12:27:11 +0100 Message-ID: References: <1360361371-4337-1-git-send-email-mengdong.lin@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id DD5A92615B6 for ; Fri, 8 Feb 2013 12:27:11 +0100 (CET) In-Reply-To: <1360361371-4337-1-git-send-email-mengdong.lin@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: mengdong.lin@intel.com Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 8 Feb 2013 17:09:31 -0500, mengdong.lin@intel.com wrote: > > From: Mengdong Lin > > A codec may allow software to hide some unused pin/cvt widgets. > > Sometimes BIOS does not enable the hidden widgets properly although they are > needed for the board. Thus the driver need to enable them as a board-specific > fixup and the whole tree will change. > > This patch implements a common code for rereading codec widgets. So the fixup > code can call it after enabling the hidden widgets. > > Signed-off-by: Mengdong Lin Applied all three patches. Thanks. Takashi > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index 3c92514..e80f835 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -1441,6 +1441,30 @@ int snd_hda_codec_new(struct hda_bus *bus, > } > EXPORT_SYMBOL_HDA(snd_hda_codec_new); > > +int snd_hda_codec_update_widgets(struct hda_codec *codec) > +{ > + hda_nid_t fg; > + int err; > + > + /* Assume the function group node does not change, > + * only the widget nodes may change. > + */ > + kfree(codec->wcaps); > + fg = codec->afg ? codec->afg : codec->mfg; > + err = read_widget_caps(codec, fg); > + if (err < 0) { > + snd_printk(KERN_ERR "hda_codec: cannot malloc\n"); > + return err; > + } > + > + snd_array_free(&codec->init_pins); > + err = read_pin_defaults(codec); > + > + return err; > +} > +EXPORT_SYMBOL_HDA(snd_hda_codec_update_widgets); > + > + > /** > * snd_hda_codec_configure - (Re-)configure the HD-audio codec > * @codec: the HDA codec > diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h > index 0be1826..e8c9442 100644 > --- a/sound/pci/hda/hda_codec.h > +++ b/sound/pci/hda/hda_codec.h > @@ -935,6 +935,7 @@ int snd_hda_bus_new(struct snd_card *card, const struct hda_bus_template *temp, > int snd_hda_codec_new(struct hda_bus *bus, unsigned int codec_addr, > struct hda_codec **codecp); > int snd_hda_codec_configure(struct hda_codec *codec); > +int snd_hda_codec_update_widgets(struct hda_codec *codec); > > /* > * low level functions > -- > 1.7.10.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >