From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Add DeviceID for Haswell HDA Date: Wed, 13 Jun 2012 08:46:32 +0200 Message-ID: References: <1339554232-3410-1-git-send-email-xingchao.wang@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 741B82414F for ; Wed, 13 Jun 2012 08:46:33 +0200 (CEST) In-Reply-To: <1339554232-3410-1-git-send-email-xingchao.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Wang Xingchao Cc: alsa-devel@alsa-project.org, fengguang.wu@intel.com, Seth Heasley List-Id: alsa-devel@alsa-project.org At Wed, 13 Jun 2012 10:23:51 +0800, Wang Xingchao wrote: > > this patch add proper id for Haswell HDA Controller. > > Signed-off-by: Wang Xingchao Oh, now ID number decreases to 0xxx? :) While we are on this: could you verify whether position_fix=4 (combo) options works for Haswell? In this mode, LPIB is used for playback positioning while POS buffer is used for capture. Seth (Cc'ed) figured out that this mode works better than the default (usually POS buf both for playback and capture) on the recent Intel controller chips, so I guess it'd be applied to Haswell, too. thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 2b6392b..f530c40 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -151,6 +151,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6}," > "{Intel, CPT}," > "{Intel, PPT}," > "{Intel, LPT}," > + "{Intel, HPT}," > "{Intel, PBG}," > "{Intel, SCH}," > "{ATI, SB450}," > @@ -3253,6 +3254,10 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = { > { PCI_DEVICE(0x8086, 0x8c20), > .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP | > AZX_DCAPS_BUFSIZE}, > + /* Haswell */ > + { PCI_DEVICE(0x8086, 0x0c0c), > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP | > + AZX_DCAPS_BUFSIZE}, > /* SCH */ > { PCI_DEVICE(0x8086, 0x811b), > .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP | > -- > 1.7.9.5 >