From: Takashi Iwai Subject: Re: [PATCH] sound/oss/pss: Fix test of unsigned in pss_reset_dsp() and pss_download_boot() Date: Wed, 16 Dec 2009 13:00:38 +0100 Message-ID: References: <4B28085A.6020101@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id C4FFD24587 for ; Wed, 16 Dec 2009 13:00:38 +0100 (CET) In-Reply-To: <4B28085A.6020101@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Roel Kluin Cc: LKML , alsa-devel@alsa-project.org, Andrew Morton List-Id: alsa-devel@alsa-project.org At Tue, 15 Dec 2009 23:06:18 +0100, Roel Kluin wrote: > > limit and jiffies are unsigned so the test does not work. > > Signed-off-by: Roel Kluin > --- > Found using coccinelle: http://coccinelle.lip6.fr/ > > diff --git a/sound/oss/pss.c b/sound/oss/pss.c > index 83f5ee2..9325f4d 100644 > --- a/sound/oss/pss.c > +++ b/sound/oss/pss.c > @@ -269,7 +269,7 @@ static int pss_reset_dsp(pss_confdata * devc) > unsigned long i, limit = jiffies + HZ/10; > > outw(0x2000, REG(PSS_CONTROL)); > - for (i = 0; i < 32768 && (limit-jiffies >= 0); i++) > + for (i = 0; i < 32768 && (limit >= jiffies); i++) No, it should use time_after_eq(limit, jiffies) instead. thanks, Takashi