From: Takashi Iwai Subject: Re: [PATCH 1/3] ASoC: Add WM8510 driver Date: Wed, 04 Jun 2008 23:38:19 +0200 Message-ID: References: <1212597211-14495-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20080604192455.GA10244@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7889F24540 for ; Wed, 4 Jun 2008 23:38:20 +0200 (CEST) In-Reply-To: <20080604192455.GA10244@opensource.wolfsonmicro.com> <1212597211-14495-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Brett Saunders , Geoffrey Wossum List-Id: alsa-devel@alsa-project.org At Wed, 4 Jun 2008 20:24:56 +0100, Mark Brown wrote: > > > Also, is the patch author you or Liam? > > We've both worked on the driver; Liam did the original driver and I've > done some fairly invasive changes to it since then, particularly to the > input paths. The Author: is showing as me since that's what git did > when I pulled the driver over into mainline for submission. OK. I just wanted to confirm since the patch had no extra From: line although the comment in the code shows Liam as the author. And, I seem to have cut some review comments accidentally during editing in the previous mail. Here is again: > diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c (snip) > +#include This is likely superfluous. > +#include Ditto. > +static int wm8510_init(struct snd_soc_device *socdev) > +{ > + struct snd_soc_codec *codec = socdev->codec; > + int ret = 0; > + > + codec->name = "WM8510"; > + codec->owner = THIS_MODULE; > + codec->read = wm8510_read_reg_cache; > + codec->write = wm8510_write; > + codec->set_bias_level = wm8510_set_bias_level; > + codec->dai = &wm8510_dai; > + codec->num_dai = 1; > + codec->reg_cache_size = sizeof(wm8510_reg); Isn't this ARRAY_SIZE()? Looks like the all codec codes set the wrong values for this... thanks, Takashi