Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0CEC388F2 for ; Thu, 22 Oct 2020 06:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5CD42245F for ; Thu, 22 Oct 2020 06:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2508190AbgJVGTD (ORCPT ); Thu, 22 Oct 2020 02:19:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:41744 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503433AbgJVGTD (ORCPT ); Thu, 22 Oct 2020 02:19:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1D622ABB2; Thu, 22 Oct 2020 06:19:02 +0000 (UTC) Date: Thu, 22 Oct 2020 08:19:01 +0200 Message-ID: From: Takashi Iwai To: Hui Wang Cc: alsa-devel@alsa-project.org, dan.carpenter@oracle.com, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Fix the return value if cb func is already registered In-Reply-To: <20201022030221.22393-1-hui.wang@canonical.com> References: <20201022030221.22393-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 22 Oct 2020 05:02:21 +0200, Hui Wang wrote: > > If the cb function is already registered, should return the pointer > of the structure hda_jack_callback which contains this cb func, but > instead it returns the NULL. > > Now fix it by replacing func_is_already_in_callback_list() with > find_callback_from_list(). > > Fixes: f4794c6064a8 ("ALSA:hda - Don't register a cb func if it is registered already") > Reported-and-suggested-by: Dan Carpenter > Cc: > Signed-off-by: Hui Wang Thanks, applied. Takashi