Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B554C432C0 for ; Fri, 29 Nov 2019 15:09:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59D8421736 for ; Fri, 29 Nov 2019 15:09:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lTgJoPv+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59D8421736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0850C16BE; Fri, 29 Nov 2019 16:08:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0850C16BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575040140; bh=kqBvlNGiU65E3F1jQIL8OhfJZXUcO8SHtdd+1b6k14Q=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lTgJoPv+aL6eobWIov2oEw1hNqI/tIp8UsIe4R4oBgpN9SpY00Qc+lCgvNwDOs6D7 ofqkQFlCKH/AQxLzzP5HLShpj6zrrJ9XOReLzQazOa7Ie/1g4f7lFfrjp8XOAguuM7 cqBhy5Kujt2WIxYyV2O53TVAnrHwKE5hDayul04M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 72153F80106; Fri, 29 Nov 2019 16:08:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F36A0F80141; Fri, 29 Nov 2019 16:08:06 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2995F80106 for ; Fri, 29 Nov 2019 16:08:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2995F80106 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6AAC4B373; Fri, 29 Nov 2019 15:08:03 +0000 (UTC) Date: Fri, 29 Nov 2019 16:08:03 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: References: <20191129143756.23941-1-kai.vehmanen@linux.intel.com> <20191129143756.23941-2-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, Nikhil Mahale Subject: Re: [alsa-devel] [PATCH 2/2] [RFC] ALSA: hda: hdmi - preserve non-MST PCM routing for Intel platforms X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 29 Nov 2019 15:47:11 +0100, Kai Vehmanen wrote: > > Hi Takashi, Nikil and others, > > On Fri, 29 Nov 2019, Kai Vehmanen wrote: > > This difference leads to some subtle differences in hdmi_find_pcm_slot() > > with regards to how non-MST monitors are assigned to PCMs. > > This patch restores the original behaviour on Intel platforms while > > keeping the new allocation policy on other platforms. > > hmm, there seems a couple of more issues. The first patch is a clear bug > that leads to segfault with SOF+patch_hdmi on some platforms (pipe B used > for single monitor HDMI case -> dev_id=1 -> non-existant pcm selected > and eventual kernel oops). > > This second patch is however trickier. Nikhil your patch changed the > default allocation a bit, so the routing might be difference also with > snd-hda-intel (i.e. not SOF) for existing platforms and this may surprise > users. Well, but the allocation itself is dynamic for DP-MST, even on Intel, so user can't expect the completely persistent index assignment. That's the reason I took Nikhil's patch (even I suggested to simplify in that way). We had a trick to assign the primary index. It still works, right? That should be the only concern. > Digging deeper, we seem to have a slight semantics difference in how > intel_pin_eld_notify() and generic_acomp_pin_eld_notify() handle > the third pipe/dev_id parameter. This is a platform-specific part, and on Intel, the assumption has been that pipe is equivalent with dev_id. If this changed, of course, we must reconsider the whole picture. For generic_acomp_pin_eld_notify(), it's gfx-driver specific, too. And currently dev_id = -1 in AMDGPU, so we don't think too much about the behavior compatibility. > Any thoughts how to solve? I first I thought making separate functions > for hdmi_find_pcm_slot() and allow platforms to define an alternative > implementation, but in this RFC patch I opted for a simpler quirk in the > function. This is becoming fairly messy I must say -- the amount of > code commentary needed is a good indication some simplifaction would > be in order. Yeah, that's a bit messy. The only expectation is the primary slot assignment -- i.e. the case only one monitor is connected. As long as this behavior is kept, I don't think any big problem with the dynamic assignment. > PS I did not have time to fully test the RFC patch, so this is just > for discussion now... Since the assignment should work with your patch somehow, I already applied it. Let's do fine tune-up during 5.5 rc cycles, if any. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel