From: Takashi Iwai Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants Date: Wed, 29 May 2019 12:07:13 +0200 Message-ID: References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-5-geert@linux-m68k.org> <20190529095730.GA7089@workstation> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190529095730.GA7089@workstation> Sender: linux-kernel-owner@vger.kernel.org To: Takashi Sakamoto Cc: Geert Uytterhoeven , alsa-devel@alsa-project.org, Arnd Bergmann , "David S . Miller" , Cong Wang , Igor Konopko , Clemens Ladisch , Matias Bjorling , linux-afs@lists.infradead.org, Eran Ben Elisha , Jiri Pirko , Jamal Hadi Salim , "Mohit P . Tahiliani" , Dan Carpenter , Joe Perches , Jaroslav Kysela , David Howells , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 29 May 2019 11:57:31 +0200, Takashi Sakamoto wrote: > > Hi, > > On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote: > > With gcc 4.1: > > > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’: > > sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’: > > sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’: > > sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type > > > > Fix this by adding the missing "ULL" suffixes. > > Add the same suffix to the last constant, to maintain consistency. > > > > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX") > > Signed-off-by: Geert Uytterhoeven > > --- > > sound/firewire/fireface/ff-protocol-latter.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Thanks for your care. > > Reviewed-by: Takashi Sakamoto Applied to sound git tree now. Thanks. Takashi