From: Takashi Iwai Subject: Re: [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c Date: Thu, 28 Jan 2016 07:22:40 +0100 Message-ID: References: <1453895151-15293-1-git-send-email-tanuk@iki.fi> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1AA382654B3 for ; Thu, 28 Jan 2016 07:22:41 +0100 (CET) In-Reply-To: <1453895151-15293-1-git-send-email-tanuk@iki.fi> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Tanu Kaskinen Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, 27 Jan 2016 12:45:51 +0100, Tanu Kaskinen wrote: > > Fixes compilation against libspeexdsp 1.2rc3. > > rate_speexrate.c includes speex_resampler.h, which depends on config.h > by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not > a good idea to include config.h from headers (I don't know/remember > why, though), which is why I include config.h from rate_speexrate.c > instead of speex_resampler.h. > > Signed-off-by: Tanu Kaskinen Applied, thanks. Takashi > --- > pph/rate_speexrate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c > index 0a1325c..8fc4cef 100644 > --- a/pph/rate_speexrate.c > +++ b/pph/rate_speexrate.c > @@ -28,6 +28,7 @@ > POSSIBILITY OF SUCH DAMAGE. > */ > > +#include "config.h" > #include > #include > #include > -- > 2.7.0.rc3 >