From: Takashi Iwai Subject: Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE Date: Sat, 24 Oct 2015 09:36:48 +0200 Message-ID: References: <1445348358-23306-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <56267E4E.8010609@linux.intel.com> <20151020193711.GF32054@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id DA9F8265716 for ; Sat, 24 Oct 2015 09:36:50 +0200 (CEST) In-Reply-To: <20151020193711.GF32054@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com, patches@opensource.wolfsonmicro.com, Pierre-Louis Bossart , lgirdwood@gmail.com, Charles Keepax List-Id: alsa-devel@alsa-project.org On Tue, 20 Oct 2015 21:37:11 +0200, Mark Brown wrote: > > On Tue, Oct 20, 2015 at 12:47:58PM -0500, Pierre-Louis Bossart wrote: > > > Since this is clearly an escape mechanism for a non-standard codec, maybe we > > should use an ID that's not in sequence, eg 0x00001000. > > 0xDEADBEEF. Also the bikeshed should be purple :) Oh, let's make it more brilliant like gold over shocking pink :) Usually the number like 0x1000 makes sense only when the lower bits are used for relevant purpose, e.g. as a sub-type definition for BESPOKE. So, type_is_bespoke() won't be "type == 0x1000" but "type & 0x1000". Takashi