From: Takashi Iwai Subject: Re: [PATCH v4 0/7] ASoC: intel - add skylake PCM driver Date: Mon, 25 May 2015 08:57:05 +0200 Message-ID: References: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3550126048D for ; Mon, 25 May 2015 08:57:07 +0200 (CEST) In-Reply-To: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org At Mon, 11 May 2015 16:23:58 +0530, Vinod Koul wrote: > > SKL has HDA controller based audio subsystem with DSP and support for I2S, > HDA, PDM links. The hda core code has been moved to sound/hda/ by Takashi > which current HDA drivers use and will also be used by ASoC SKL driver. > > The SKL platform driver will load and create the soc_hdac_bus which embeds > the hdac_bus, same for hdac_device (hda codecs) and hdac_stream (pcms) This > is on top of hdac code in Takashi's topic/hda > > This patch provides the match function for asoc type hda codecs and let's > them get enumerated by hdac. The second patch in this series adds the > controller specific soc code. Common parts are in hdac core with changes > introduced as part of SKL controller in soc part. Then we add the rest of > controller PCM driver code (still HDA) and last patch breaks the HDA streams > to host and link which will allow insertion of DSP in between these links. > > The subsequent series will add IPC driver for SKL (using common IPC > routines), then DSP topology handlers, DSP code with I2S support and then > lastly when DFW is accepted then its handlers. > > This patch series adds the hda codec match functions followed by asoc hda > controller routines, then SKL PCM driver and last decouples the controller > for splitting the links Merging this without the codec driver would be rather confusing for users, since it gives a conflicting driver that doesn't work at all. I suppose that the merge should be pending until the complete implementation of ASoC HDA. Comments? Takashi > > Fixes in v4: > Updates changelog in patch1 and few other patches > Address Takashi's comment > Address Marks comments > > Jeeja KP (7): > ASoC: hda - add ASoC HDA codec match function > ALSA: hda - add new HDA registers > ASoC: hda - add asoc hda core bus, controller and stream helpers > ASoC: intel - add Skylake HDA platform driver > ASoC: intel - add Skylake HDA audio driver > ASoC: intel - add makefile support for SKL driver > ASoC: intel - adds support for decoupled mode in skl driver > > include/sound/hda_register.h | 88 ++++ > include/sound/soc-hda-codec.h | 49 ++ > include/sound/soc-hdaudio.h | 360 +++++++++++++ > sound/soc/Kconfig | 1 + > sound/soc/Makefile | 1 + > sound/soc/hda/Kconfig | 3 + > sound/soc/hda/Makefile | 4 + > sound/soc/hda/soc-hda-codec.c | 89 ++++ > sound/soc/hda/soc-hdac-bus.c | 115 +++++ > sound/soc/hda/soc-hdac-controller.c | 296 +++++++++++ > sound/soc/hda/soc-hdac-stream.c | 409 +++++++++++++++ > sound/soc/intel/Kconfig | 17 + > sound/soc/intel/Makefile | 1 + > sound/soc/intel/skylake/Makefile | 3 + > sound/soc/intel/skylake/hda-skl-pcm.c | 937 ++++++++++++++++++++++++++++++++++ > sound/soc/intel/skylake/hda-skl.c | 670 ++++++++++++++++++++++++ > sound/soc/intel/skylake/hda-skl.h | 74 +++ > 17 files changed, 3117 insertions(+) > create mode 100644 include/sound/soc-hda-codec.h > create mode 100644 include/sound/soc-hdaudio.h > create mode 100644 sound/soc/hda/Kconfig > create mode 100644 sound/soc/hda/Makefile > create mode 100644 sound/soc/hda/soc-hda-codec.c > create mode 100644 sound/soc/hda/soc-hdac-bus.c > create mode 100644 sound/soc/hda/soc-hdac-controller.c > create mode 100644 sound/soc/hda/soc-hdac-stream.c > create mode 100644 sound/soc/intel/skylake/Makefile > create mode 100644 sound/soc/intel/skylake/hda-skl-pcm.c > create mode 100644 sound/soc/intel/skylake/hda-skl.c > create mode 100644 sound/soc/intel/skylake/hda-skl.h > > -- > 1.9.1 >