From: Takashi Iwai Subject: Re: [PATCH - alsa-lib 1/1] include/global.h: missing struct on FreeBSD Date: Sun, 11 Jan 2015 16:57:39 +0100 Message-ID: References: <54b0f97b.ca51c20a.1b71.ffffc3db@mx.google.com> <1974835.OcM2UqamNN@nu-athena> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AEFEE260320 for ; Sun, 11 Jan 2015 16:57:39 +0100 (CET) In-Reply-To: <1974835.OcM2UqamNN@nu-athena> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rumko Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 11 Jan 2015 12:17:31 +0100, Rumko wrote: > > On Sunday 11 January 2015 11:27:52 Takashi Iwai wrote: > > At Sat, 10 Jan 2015 11:04:59 +0100, > > > > rumko@rumko.net wrote: > > > From: Rumko > > > > > > On FreeBSD, struct timespec is not accessible through , > > > but through . Add specific include for that header > > > on that platform only. > > > > > > Signed-off-by: Rumko > > > > If you give your sign-off, please give the full real name. > > Sorry about that, was just following > http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers > It specifically adds the -s flag to format-patch as instructions for generating > the patchset. > > Should I resubmit without it? We follow the policy of Linux kernel development for the user-space stuff in principle. See Documentation/SubmittingPatches of Linux driver tree, "Sign your work" section. You need to give the real name. thanks, Takashi