From: Takashi Iwai Subject: Re: [PATCH] ALSA: compress: Fix compress device unregister. Date: Thu, 19 Sep 2013 18:41:28 +0200 Message-ID: References: <1379090597-7096-1-git-send-email-liam.r.girdwood@linux.intel.com> <1379090597-7096-2-git-send-email-liam.r.girdwood@linux.intel.com> <20130916041501.GK17188@intel.com> <20130916042211.GM17188@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 2C341261AE0 for ; Thu, 19 Sep 2013 18:39:15 +0200 (CEST) In-Reply-To: <20130916042211.GM17188@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown List-Id: alsa-devel@alsa-project.org At Mon, 16 Sep 2013 09:52:11 +0530, Vinod Koul wrote: > > On Mon, Sep 16, 2013 at 09:45:01AM +0530, Vinod Koul wrote: > > On Fri, Sep 13, 2013 at 05:43:17PM +0100, Liam Girdwood wrote: > > > snd_unregister_device() should return the device type and not stream > > > direction. > > Thanks for fixing this, I saw this but didnt get time to fix it. > > > > Acked-By: Vinod Koul > > Tested-By: Vinod Koul > > Also pls CC stable, this fixed would help in older kernels too I applied this now with these tags, but a pull request to Linus will be postponed until the next week since I've been traveling now. thanks, Takashi > > ~Vinod > > > > Is there a Tested-Acked-?? > > > > ~Vinod > > > > > > Signed-off-by: Liam Girdwood > > > --- > > > sound/core/compress_offload.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > > > index a9ae4f3..fba7e7a 100644 > > > --- a/sound/core/compress_offload.c > > > +++ b/sound/core/compress_offload.c > > > @@ -849,7 +849,8 @@ static int snd_compress_dev_disconnect(struct snd_device *device) > > > struct snd_compr *compr; > > > > > > compr = device->device_data; > > > - snd_unregister_device(compr->direction, compr->card, compr->device); > > > + snd_unregister_device(SNDRV_DEVICE_TYPE_COMPRESS, compr->card, > > > + compr->device); > > > return 0; > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > > -- > > -- >