From: Takashi Iwai Subject: Re: [PATCH v3 0/5] ALSA: snd-usb: add support for DSD Date: Wed, 17 Apr 2013 12:59:36 +0200 Message-ID: References: <1366128100-9778-1-git-send-email-zonque@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D8CE226160C for ; Wed, 17 Apr 2013 12:59:37 +0200 (CEST) In-Reply-To: <1366128100-9778-1-git-send-email-zonque@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: ray@auraliti.com, andreas@akdesigninc.com, alsa-devel@alsa-project.org, clemens@ladisch.de, demian@auraliti.com List-Id: alsa-devel@alsa-project.org At Wed, 17 Apr 2013 00:01:35 +0800, Daniel Mack wrote: > > In contrast to the first two approaches, this one keeps the userspace > unaware of the actual transport on the bus. > > More specifically, the DSD_U16_LE format may be implemented to actually > send DOP samples to the device, depending on the quirks entries. > > Also, as there is quite some confusion in both data file formats as > well as hardware sample formats about whether to stuff the oldest bit > in the MSB or the LSB of a byte, ALSA defines that now to be in the > MSB, as far as the ALSA userspace layer is concerned. The driver > learned functions to re-encode the bytes according to what the hardware > supports. > > I also wrote a very basic test tool which I published here: > > https://github.com/zonque/alsa-dsd-player > > > Thanks, > Daniel > > Daniel Mack (5): > ALSA: add DSD formats > ALSA: snd-usb: use ep->stride from urb callbacks > ALSA: snd-usb: add support for DSD DOP stream transport > ALSA: snd-usb: add support for bit-reversed byte formats > ALSA: snd-usb: add quirks handler for DSD streams All patches look OK to me through a quick glance, so I'm going to apply them later, unless anyone has objection. thanks, Takashi > > include/sound/pcm.h | 2 + > include/uapi/sound/asound.h | 4 +- > sound/core/pcm.c | 2 + > sound/core/pcm_misc.c | 8 +++ > sound/usb/card.h | 8 +++ > sound/usb/endpoint.c | 9 ++++ > sound/usb/format.c | 3 ++ > sound/usb/pcm.c | 118 ++++++++++++++++++++++++++++++++++++------- > sound/usb/quirks.c | 28 ++++++++++ > sound/usb/quirks.h | 4 ++ > 10 files changed, 167 insertions(+), 19 deletions(-) > > -- > 1.7.10.4 >