From: Takashi Iwai Subject: Re: [PATCH v2] Add M2Tech hiFace USB-SPDIF driver Date: Fri, 22 Feb 2013 17:18:40 +0100 Message-ID: References: <1360537887-9427-1-git-send-email-ao2@amarulasolutions.com> <1360775505-13106-1-git-send-email-ao2@amarulasolutions.com> <512798F4.1030607@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <512798F4.1030607@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, patch@alsa-project.org, Antonio Ospite , Clemens Ladisch , fchecconi@gmail.com, Pietro Cipriano , alberto@amarulasolutions.com, Michael Trimarchi List-Id: alsa-devel@alsa-project.org At Fri, 22 Feb 2013 17:12:36 +0100, Daniel Mack wrote: > > > + ret = hiface_pcm_init(chip, quirk ? quirk->extra_freq : 0); > > + if (ret < 0) > > + goto err_chip_destroy; > > + > > + ret = snd_card_register(chip->card); > > + if (ret < 0) { > > + snd_printk(KERN_ERR "cannot register " CARD_NAME " card\n"); > > Not sure, but I think it might be better to use dev_{err,info,dgb} here, > so the logging can be grouped to individual devices. Takashi, any > opinion on that? Yeah, I think we should move to dev_*() somehow. At least, for most of generic outputs with snd_printk() can be converted with more standard functions. It's fine that a new driver starts using dev_*(), then we'll convert the old ones eventually later. Debug prints with snd_printd() or snd_printdd() are different questions, though. We have another control factor over the behavior of these functions, so conversions should be done carefully. Takashi