From: Takashi Iwai Subject: Re: [patch] move dereference after null check Date: Mon, 16 Nov 2009 17:15:37 +0100 Message-ID: References: <20091116161124.GB29365@rakim.wolfsonmicro.main> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id E6DF8245BA for ; Mon, 16 Nov 2009 17:15:37 +0100 (CET) In-Reply-To: <20091116161124.GB29365@rakim.wolfsonmicro.main> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Dan Carpenter , lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org At Mon, 16 Nov 2009 16:11:24 +0000, Mark Brown wrote: > > On Mon, Nov 16, 2009 at 11:06:33AM +0200, Dan Carpenter wrote: > > The 'jack' variable was dereference before the NULL check so this patch > > moves the dereference later. > > > > regards, > > dan carpenter > > > > Signed-off-by: Dan Carpenter > > This does not apply to the current ASoC code, it appears that someone > else has already provided an equivalent change. When doing work like > this it's normally best to work against -next to help avoid duplication > such as this. Yep. FYI, it's the commit below: commit 4f066173fe8deb8874f41917e5d26ea2e0c46e3b Author: Julia Lawall Date: Sat Oct 17 08:32:56 2009 +0200 ASoC: Move dereference after NULL test thanks, Takashi