From: Takashi Iwai Subject: Re: [PATCH 2/5] sound: soc: skylake: no need to check return value of debugfs_create functions Date: Mon, 24 Jun 2019 15:15:26 +0200 Message-ID: References: <20190614094756.2965-1-gregkh@linuxfoundation.org> <20190614094756.2965-2-gregkh@linuxfoundation.org> <20190624105334.GJ5316@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DF8E9F8065B for ; Mon, 24 Jun 2019 15:15:27 +0200 (CEST) In-Reply-To: <20190624105334.GJ5316@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Mark Brown Cc: Cezary Rojewski , Greg Kroah-Hartman , Jie Yang , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, 24 Jun 2019 12:53:34 +0200, Mark Brown wrote: > > On Sat, Jun 22, 2019 at 10:39:11PM +0200, Takashi Iwai wrote: > > > Well, I just wonder whether you have ever seen a case where the > > debugfs creation failed. Or more practically, would it fail silently > > at all? > > > If there can be a silent failure, then it's bad to just ignore, yes. > > We may need either to make it more obvious or return an error. > > Currently debugfs doesn't report any errors other than via the return > codes (at least in the common creation stuff) so it's up to the callers > to do that. So this should be changed to follow a la sysfs creation error, IMO. At least, the name conflicts etc should be reported more obviously. thanks, Takashi