From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally Date: Mon, 30 Jul 2018 08:48:08 +0200 Message-ID: References: <20180727162805.20785-1-pierre-louis.bossart@linux.intel.com> <20180728144843.GO2414@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1A9E62676E2 for ; Mon, 30 Jul 2018 08:48:08 +0200 (CEST) In-Reply-To: <20180728144843.GO2414@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: liam.r.girdwood@linux.intel.com, vkoul@kernel.org, alsa-devel@alsa-project.org, Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On Sat, 28 Jul 2018 16:48:43 +0200, Mark Brown wrote: > > On Fri, Jul 27, 2018 at 11:28:05AM -0500, Pierre-Louis Bossart wrote: > > Make this helper inline function available for all platforms. This > > helps solve 0-day compilation issues when CONFIG_SND_DMA_SGBUF is not > > defined. > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. I asked Pierre for resubmission in a couple of days ago since your usual notification post wasn't sent / received for the v1 post by some reason... In anyway, I submitted the incremental fix now. thanks, Takashi