From: Takashi Iwai Subject: Re: [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Date: Thu, 21 Apr 2016 13:02:33 +0200 Message-ID: References: <1461220058-1378-1-git-send-email-vinod.koul@intel.com> <20160421105304.GN2274@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 69118261A03 for ; Thu, 21 Apr 2016 13:02:34 +0200 (CEST) In-Reply-To: <20160421105304.GN2274@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 21 Apr 2016 12:53:04 +0200, Vinod Koul wrote: > > On Thu, Apr 21, 2016 at 09:19:56AM +0200, Takashi Iwai wrote: > > On Thu, 21 Apr 2016 08:27:35 +0200, > > Vinod Koul wrote: > > > > > > This series adds SKL-i2c conf for simple PCM topology graph > > > > > > Changes in v3: > > > > > > - remove bin blobs, now they are generated in install step > > > > This isn't good in general. Usually all installed files are generated > > in the normal make step, and make-install only copies them. There are > > a few reasons: > > - Invoking a random program as root is a security risk. > > - This may create a file by root in the working directory, and either > > it's not always possible (e.g. on NFS) or it may be left undeletable > > after make install. > > Right, that is good point indeed. > > So what is your suggestion then? Just put the normal make rule and generate it at the normal make step (only when needed). Takashi