From: Takashi Iwai Subject: Re: [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver Date: Tue, 02 Jun 2015 12:53:00 +0200 Message-ID: References: <1431341645-2457-1-git-send-email-vinod.koul@intel.com> <1431341645-2457-6-git-send-email-vinod.koul@intel.com> <20150529174115.GR21577@sirena.org.uk> <20150602104516.GH14071@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A62D0260517 for ; Tue, 2 Jun 2015 12:53:01 +0200 (CEST) In-Reply-To: <20150602104516.GH14071@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Vinod Koul , liam.r.girdwood@linux.intel.com, patches.audio@intel.com, Jeeja KP , "Subhransu S. Prusty" List-Id: alsa-devel@alsa-project.org At Tue, 2 Jun 2015 11:45:16 +0100, Mark Brown wrote: > > On Fri, May 29, 2015 at 08:25:01PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > > +/* PCI register access. */ > > > > +static void pci_azx_writel(u32 value, u32 __iomem *addr) > > > > +{ > > > > + writel(value, addr); > > > > +} > > > > These wrappers are setting off alarm bells - why can't we just use the > > > called functions directly, and given the parameters (which have just a > > > raw pointer and value) what else could the implementation be? > > > Tegra has no direct byte access but only aligned 32bit accesses. > > That's why we have the redirection. > > Ugh, and the functions are macros so can't be used directly. I'd still > expect to see these ops be defined in some central place and reused. Maybe we can lift up some time later, but it's nothing more than an optimization, so in a low priority for now. Takashi