From: Takashi Iwai Subject: Re: [PATCH] alsa-lib: Provide a CLOCK_MONOTONIC_RAW timestamp type Date: Thu, 10 Jul 2014 17:33:18 +0200 Message-ID: References: <1404831152-8064-1-git-send-email-broonie@kernel.org> <53BD9A92.6090806@ladisch.de> <53BEAD00.5050304@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 0E2CD261ABF for ; Thu, 10 Jul 2014 17:33:21 +0200 (CEST) In-Reply-To: <53BEAD00.5050304@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, Mark Brown , Clemens Ladisch , Daniel Thompson , Mark Brown List-Id: alsa-devel@alsa-project.org At Thu, 10 Jul 2014 10:10:56 -0500, Pierre-Louis Bossart wrote: > > On 7/9/14, 2:40 PM, Clemens Ladisch wrote: > > Takashi Iwai wrote: > >> Currently, the timestamp mode is set implicitly in alsa-lib pcm_hw.c: > >> - When kernel PCM protocol version is high enough, alsa-lib hw prefers > >> the monotonic always (if available), then set pcm->monotonic = 1. > >> - Application can ask whether the current timestamp is monotonic or > >> not via snd_pcm_hw_params_is_monotonic(). > >> So, only adding the flag above doesn't suffice. If we need to add a > >> new mode, the API has to be extended as well. > >> > >> But how? The current API assumes that the monotonic mode was already > >> determined before hw_params. We may add a set of new hw_params get > >> and set calls for tstamp mode while keeping the old API. This would > >> be one option. Another option would be to add a new PCM open flag > >> SND_PCM_TSTAMP_MONOTONIC_RAW, and snd_pcm_hw_params_is_monotonic_raw() > >> function. The latter is easier (a simpler addition), while the former > >> is more extensible to newer formats in future. > > > > These timestamps cannot be handled by hardware drivers; they are always > > read by the ALSA framework, in software. Furthermore, switching between > > MONOTONIC and MONOTONIC_RAW is possible at any time. Therefore, the > > timestamp mode should be made a part of sw_params; just add a field > > named tstamp_mode ... > > Humm... why would anyone switch modes at run time during > playback/capture? I have seen timestamps being used mainly to track that > playback/capture is happening as predicted, improve A/V sync or sleep > for a predictable time with interrupts disabled (PulseAudio, Android, > ChromeOS, etc). NTP adjustments are really adding noise more than > information for those usages. I have yet to see a case where the use of > those NTP adjustments would matter for userspace, and for now I really > don't see the point of making this dynamically configurable as a > software parameter. I would personally make this new mode the default. As Clemens already pointed, if the application itself refers to the timestamp and compares with the own timestamp by CLOCK_MONOTONIC, using CLOCK_MONOTONIC_RAW would break. So we cannot replace it with CLOCK_MONOTONIC_RAW silently, unfortunately. Takashi