From: Takashi Iwai Subject: Re: [PATCH] OSS: missing parentheses? Date: Wed, 18 Feb 2009 11:40:07 +0100 Message-ID: References: <499BD194.4070707@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 81C0A10386D for ; Wed, 18 Feb 2009 11:40:08 +0100 (CET) In-Reply-To: <499BD194.4070707@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Roel Kluin Cc: alsa-devel@alsa-project.org, Andrew Morton List-Id: alsa-devel@alsa-project.org At Wed, 18 Feb 2009 10:15:00 +0100, Roel Kluin wrote: > > Please review. > --------------------------->8-------------8<------------------------------ > Add missing parentheses > > Signed-off-by: Roel Kluin > --- > diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c > index 25f3a22..7f377ec 100644 > --- a/sound/oss/pas2_card.c > +++ b/sound/oss/pas2_card.c > @@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config) > * 0x80 > */ , 0xB88); > > - pas_write(0x80 > - | joystick?0x40:0 > - ,0xF388); > + pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388); Yes, obviously a bug. Applied now. Thanks! Takashi