From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Change HP dv7 (103c:30f4) quirk from hp-m4 to hp-dv5 model Date: Fri, 13 Feb 2009 08:49:17 +0100 Message-ID: References: <200902121727.27839.herton@mandriva.com.br> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D4EF51038C9 for ; Fri, 13 Feb 2009 08:49:17 +0100 (CET) In-Reply-To: <200902121727.27839.herton@mandriva.com.br> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Herton Ronaldo Krzesinski Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 12 Feb 2009 17:27:27 -0200, Herton Ronaldo Krzesinski wrote: > > Change HP dv7 quirk: although reported to work with hp-m4 model > (https://bugzilla.novell.com/show_bug.cgi?id=445321), the original > report doesn't contain info about testing of internal microphone. > > Recently I received a report about internal mic not working > (https://qa.mandriva.com/show_bug.cgi?id=44855#c193), this must be > related with the forced line in on pin 0x0e done with hp-m4 model. Thus > change the current quirk from STAC_HP_M4 to STAC_HP_DV5, later reported > to be fixed on a provided kernel with this change > (https://qa.mandriva.com/show_bug.cgi?id=44855#c196). > > Signed-off-by: Herton Ronaldo Krzesinski Applied now. Thanks. I guess we can change all 0x30f* entries. Though, I'm a bit conservative to change 2.6.29 code at this stage. Maybe we should first change the code for the next kernel using SND_PCI_QUIRK_MASK(). Takashi > --- > sound/pci/hda/patch_sigmatel.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c > index 3c84817..efc1aff 100644 > --- a/sound/pci/hda/patch_sigmatel.c > +++ b/sound/pci/hda/patch_sigmatel.c > @@ -1811,7 +1811,7 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = { > SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f2, > "HP dv5", STAC_HP_M4), > SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4, > - "HP dv7", STAC_HP_M4), > + "HP dv7", STAC_HP_DV5), > SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7, > "HP dv4", STAC_HP_DV5), > SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc, > -- > 1.6.1.3 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >